Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DNS provider for F5 XC #2409

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add DNS provider for F5 XC #2409

wants to merge 2 commits into from

Conversation

ldez
Copy link
Member

@ldez ldez commented Jan 27, 2025 •
edited
Loading

  • adds a description to your PR
  • have a homogeneous design with the other providers
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment) 
    make build
rm -rf .lego

F5XC_API_TOKEN="xxx" \
F5XC_TENANT_NAME="yyy" \
F5XC_GROUP_NAME="zzz" \
./dist/lego -m your_email@example.com --dns f5xc -d '*.example.com' -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    Note the wildcard domain is important.
  • pass the linter
  • do go mod tidy

Ping @Ewouddlb, can you run the command (with your domain, email, credentials, etc.)?

Closes #2408

How to test this PR?
  1. You need Go
  2. Checkout the PR: 
    git clone https://github.com/ldez/lego.git
cd lego
git checkout feat/f5xc
  3. Compile lego:
    • if you have make: make build
    • if you don't make make: go build -o dist/lego ./cmd/lego
  4. Run the following command with your information (email, domain, credentials): 
    F5XC_API_TOKEN="xxx" \
F5XC_TENANT_NAME="yyy" \
F5XC_GROUP_NAME="zzz" \
./dist/lego -m your_email@example.com --dns f5xc -d ''*.example.com' -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    The wildcard domain is important
  5. Before each run of the command, you should clean your local environment: 
    rm -rf .lego

@ldez ldez changed the title Add DNS provider for Add DNS provider for F5 XC Jan 27, 2025
@Ewouddlb
Copy link

Hi @ldez

Thanks a lot for the fast implementation. I will try to test this as quick as possible. It can take a few days as I need request some resources on distributed cloud side.

I will keep you up to date.

Best regards,
Ewoud

@ldez
Copy link
Member Author

ldez commented Feb 4, 2025

@Ewouddlb any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/dnsprovider enhancement state/need-user-tests Need users to test functionality
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for provider: F5 - XC - Distributed Cloud - Volterra
2 participants
@ldez @Ewouddlb